fix(report): give preset reasons a stable non-empty slug for CJK labels

ban_settings() derived each reason slug via sanitize_key(label), which
strips CJK text to an empty string; the frontend filter then discarded
every reason (including the schema defaults) and fell back to the
hard-coded list. Derive the slug from an ASCII key when possible and
from a stable md5 short hash of the label otherwise, and relax the
frontend filter to the label only. Adds a WP-stub harness that verifies
the defaults path end to end (tests/dev/verify-ban-settings-defaults.php).
This commit is contained in:
2026-09-20 14:48:28 +08:00
parent 67547fdf23
commit 3d4179a756
4 changed files with 88 additions and 4 deletions
+1 -1
View File
@@ -41,7 +41,7 @@
name: String((cat && (cat.name || cat.label || cat.t)) || ''), name: String((cat && (cat.name || cat.label || cat.t)) || ''),
}; };
}) })
.filter(function (cat) { return cat.slug !== '' && cat.name !== ''; }); .filter(function (cat) { return cat.name !== ''; });
if (items.length) return items; if (items.length) return items;
} }
return [ return [
+10 -3
View File
@@ -216,14 +216,21 @@ class UserRuntime {
public static function ban_settings(): array { public static function ban_settings(): array {
$settings = self::read_report_section(); $settings = self::read_report_section();
// 预置原因:group 数组 [{t:...}](对齐参考主题)或旧版每行一条文本 // 预置原因:group 数组 [{t:...}](对齐参考主题)或旧版每行一条文本。
// slug 不能用 sanitize_key(标签) 派生:中文标签会被清洗成空串,
// 导致前端按 slug 非空过滤后整列表被丢弃。改用标签内容的稳定短哈希
// (跨请求一致、可通过服务端 sanitize_key、ASCII 标签同样稳定)。
$reasons_raw = $settings['ban_preset_reason'] ?? null; $reasons_raw = $settings['ban_preset_reason'] ?? null;
$reasons = []; $reasons = [];
$reason_slug = static function (string $text): string {
$key = sanitize_key($text);
return $key !== '' ? $key : substr(md5($text), 0, 12);
};
if (is_array($reasons_raw)) { if (is_array($reasons_raw)) {
foreach ($reasons_raw as $row) { foreach ($reasons_raw as $row) {
$text = trim((string) ($row['t'] ?? '')); $text = trim((string) ($row['t'] ?? ''));
if ($text !== '') { if ($text !== '') {
$reasons[] = ['slug' => sanitize_key($text), 'name' => sanitize_text_field($text)]; $reasons[] = ['slug' => $reason_slug($text), 'name' => sanitize_text_field($text)];
} }
} }
} else { } else {
@@ -234,7 +241,7 @@ class UserRuntime {
} }
$parts = explode('|', $line, 2); $parts = explode('|', $line, 2);
$reasons[] = [ $reasons[] = [
'slug' => sanitize_key($parts[0]), 'slug' => $reason_slug((string) ($parts[1] ?? $parts[0])),
'name' => sanitize_text_field($parts[1] ?? $parts[0]), 'name' => sanitize_text_field($parts[1] ?? $parts[0]),
]; ];
} }
@@ -0,0 +1,73 @@
<?php
/**
* Local harness: verify UserRuntime::ban_settings() returns the schema
* default preset reasons when the option is empty (never saved).
* Run: php tests/dev/verify-ban-settings-defaults.php
*/
error_reporting(E_ALL & ~E_DEPRECATED);
// ---- WP stubs ----
$GLOBALS['__test_options'] = [];
function get_option($key, $default = false) {
return $GLOBALS['__test_options'][$key] ?? $default;
}
function update_option($key, $value) { $GLOBALS['__test_options'][$key] = $value; return true; }
function sanitize_key($key) { return preg_replace('/[^a-z0-9_\-]/', '', strtolower((string) $key)); }
function sanitize_text_field($value) { return trim(strip_tags((string) $value)); }
function sanitize_textarea_field($value) { return trim(strip_tags((string) $value)); }
function wp_kses_post($value) { return (string) $value; }
function __($text, $domain = null) { return $text; }
function esc_html__($text, $domain = null) { return $text; }
function esc_attr__($text, $domain = null) { return $text; }
function apply_filters($tag, $value) { return $value; }
function add_filter(...$args) {}
function do_action(...$args) {}
function add_action(...$args) {}
function get_current_user_id() { return 1; }
function is_user_logged_in() { return true; }
function wp_unslash($value) { return $value; }
function current_time($type) { return date('Y-m-d H:i:s'); }
function get_theme_file_uri($file = '') { return 'https://example.test/wp-content/themes/aksrt/' . ltrim((string) $file, '/'); }
function get_theme_file_path($file = '') { return dirname(__DIR__, 2) . '/' . ltrim((string) $file, '/'); }
function get_template_directory() { return dirname(__DIR__, 2); }
function esc_url_raw($url) { return (string) $url; }
function esc_html($text) { return (string) $text; }
function esc_attr($text) { return (string) $text; }
define('ABSPATH', __DIR__ . '/');
$repo = dirname(__DIR__, 2);
foreach (['DomainGroups', 'DisplayPageGroups', 'CreditsPaymentGroups', 'CategoryIntegrationGroups', 'AuthReader', 'HomepageReader', 'FacadeBulk'] as $trait_file) {
require $repo . '/src/Settings/' . $trait_file . '.php';
}
require $repo . '/src/Admin/Schema/SchemaUsers.php';
require $repo . '/src/Admin/SchemaProvider.php';
require $repo . '/src/Settings/Settings.php';
require $repo . '/src/Settings/UserRuntime.php';
$reasons = \AKSRT\Settings\UserRuntime::ban_settings()['reasons'] ?? null;
$report = \AKSRT\Settings\UserRuntime::report_settings();
echo "=== ban_settings()['reasons'] (empty option) ===\n";
var_export($reasons);
echo "\n\n=== report_settings() ===\n";
var_export([
'enabled' => $report['enabled'] ?? null,
'img_enabled' => $report['img_enabled'] ?? null,
'desc_len' => isset($report['desc']) ? strlen($report['desc']) : null,
]);
// 再模拟“后台保存过自定义原因”的场景
$GLOBALS['__test_options']['aksrt_settings'] = [
'ban_preset_reason' => [
['t' => '自定义原因A'],
['t' => '自定义原因B'],
],
];
\AKSRT\Settings\Settings::flush_settings_cache();
$stored = \AKSRT\Settings\UserRuntime::ban_settings()['reasons'] ?? null;
echo "\n\n=== ban_settings()['reasons'] (custom stored) ===\n";
var_export($stored);
echo "\n";
@@ -108,6 +108,10 @@ test('ban/report settings page mirrors the reference theme schema', () => {
// 缺键回退 schema 默认值(参考主题 _pz 语义):运行时经 read_domain 读取, // 缺键回退 schema 默认值(参考主题 _pz 语义):运行时经 read_domain 读取,
// 裸 get_all() 会让未保存过分区的站点拿不到 ban_preset_reason 默认值。 // 裸 get_all() 会让未保存过分区的站点拿不到 ban_preset_reason 默认值。
assert.match(runtime, /read_domain\('users', 'report'\)/) assert.match(runtime, /read_domain\('users', 'report'\)/)
// 预置原因 slug 不得由 sanitize_key(标签) 直接派生:中文标签会被清洗成
// 空串,前端按 slug 非空过滤后整张原因列表会被丢弃。ASCII 键优先,
// 否则用标签内容的稳定 md5 短哈希。
assert.match(runtime, /md5\(\$text\)/)
// 死链清理:user_report_categories 从不是真实存储键,解析器必须删除。 // 死链清理:user_report_categories 从不是真实存储键,解析器必须删除。
assert.ok(!runtime.includes('parse_report_categories'), 'dead parse_report_categories must stay removed') assert.ok(!runtime.includes('parse_report_categories'), 'dead parse_report_categories must stay removed')
assert.ok(!runtime.includes('user_report_categories'), 'dead user_report_categories key must stay removed') assert.ok(!runtime.includes('user_report_categories'), 'dead user_report_categories key must stay removed')